Return success from RemoveAgent when the Agent MSI/Product is not installed
#29577
Conversation
clarkb7
added
changelog/no-changelog
team/windows-agent
qa/done
clarkb7
changed the title
RemoveAgent when the Agent MSI/Product is not installed.RemoveAgent when the Agent MSI/Product is not installed
Regression DetectorRegression Detector ResultsRun ID: 1d137c89-d14f-4f47-8e01-43ec6ceec2aa Metrics dashboard Target profiles Baseline: 3c4c7ec Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | idle_all_features | memory utilization | +1.51 | [+1.42, +1.59] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.48 | [+0.38, +0.58] | 1 | Logs |
| ➖ | idle | memory utilization | +0.19 | [+0.14, +0.24] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.09 | [+0.04, +0.14] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.03 | [-0.78, +0.84] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.05, +0.07] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.56 | [-1.29, +0.17] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.75 | [-3.27, +1.77] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.81 | [-3.55, +1.93] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45220507 --os-family=ubuntuNote: This applies to commit 123eaf2 |
clarkb7
force-pushed
the
branden.clark/fleet-remove-agent
branch
from
f629b94 to
123eaf2
Compare
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Return success from
RemoveAgentwhen the Agent MSI/Product is not installed.Motivation
It was preventing
installer remove datadog-agentfrom removing the Agent package from the repository. Andinstaller install datadog-agentwould fail since its "already installed".Describe how to test/QA your changes
N/A, E2E test installs the agent package, removes with the MSI, then removes the agent package
Possible Drawbacks / Trade-offs
Additional Notes
installer remove datadog-agentwill still throw an error if the Agent package is not in the repositoryno changelog, unreleased feature